Author asvetlov
Recipients Eli.Stevens, asvetlov, belopolsky, mark.dickinson, mark.wiebe, pitrou
Date 2012-04-04.13:17:28
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1333545449.14.0.665155041742.issue11734@psf.upfronthosting.co.za>
In-reply-to
Content
Tests passed, looks good. Code is also looks ok.
Documentation is out-of-date. Patch cannot be applied to struct.rst from default branch.
Compilation generates warning messages on gcc 4.6.1:

/home/andrew/projects/py3k/Modules/_struct.c: In function ‘nu_halffloat’:
/home/andrew/projects/py3k/Modules/_struct.c:489:5: warning: pointer targets in passing argument 1 of ‘_PyFloat_Unpack2’ differ in signedness [-Wpointer-sign]
Include/floatobject.h:108:20: note: expected ‘const unsigned char *’ but argument is of type ‘const char *’
/home/andrew/projects/py3k/Modules/_struct.c: In function ‘np_halffloat’:
/home/andrew/projects/py3k/Modules/_struct.c:712:5: warning: pointer targets in passing argument 2 of ‘_PyFloat_Pack2’ differ in signedness [-Wpointer-sign]
Include/floatobject.h:87:17: note: expected ‘unsigned char *’ but argument is of type ‘char *’

After fixing warnings and structure.rst I like to see that patch in standard library.
History
Date User Action Args
2012-04-04 13:17:29asvetlovsetrecipients: + asvetlov, mark.dickinson, belopolsky, pitrou, Eli.Stevens, mark.wiebe
2012-04-04 13:17:29asvetlovsetmessageid: <1333545449.14.0.665155041742.issue11734@psf.upfronthosting.co.za>
2012-04-04 13:17:28asvetlovlinkissue11734 messages
2012-04-04 13:17:28asvetlovcreate