Author kristjan.jonsson
Recipients ajaksu2, akuchling, belopolsky, benjamin.peterson, brett.cannon, georg.brandl, kristjan.jonsson, loewis, meador.inge, skrah, vstinner
Date 2012-03-26.11:35:04
SpamBayes Score 1.7419e-06
Marked as misclassified No
Message-id <1332761705.74.0.677024022847.issue3367@psf.upfronthosting.co.za>
In-reply-to
Content
I'm sure you didn't intend to use words such as "wrong" and "useless" Victor.  Perhaps n must be 0 even for argc>0, but I did that as an afterthought. Which is the reason I asked you to take a look rather than committing this right away.

Please allow me to point out that relying on an extra NULL pointer at the end of argv is dangerous.  C makes no such guarantees with main() and you are coupling implementation details betweeen layers using this.  The "correct" thing to do is to simply not dereference argv at argc or beyond.
History
Date User Action Args
2012-03-26 11:35:05kristjan.jonssonsetrecipients: + kristjan.jonsson, loewis, akuchling, brett.cannon, georg.brandl, belopolsky, vstinner, ajaksu2, benjamin.peterson, skrah, meador.inge
2012-03-26 11:35:05kristjan.jonssonsetmessageid: <1332761705.74.0.677024022847.issue3367@psf.upfronthosting.co.za>
2012-03-26 11:35:05kristjan.jonssonlinkissue3367 messages
2012-03-26 11:35:04kristjan.jonssoncreate