Author kristjan.jonsson
Recipients ajaksu2, akuchling, belopolsky, benjamin.peterson, brett.cannon, georg.brandl, kristjan.jonsson, loewis, meador.inge, skrah, vstinner
Date 2012-03-26.09:54:51
SpamBayes Score 3.91046e-09
Marked as misclassified No
Message-id <1332755692.44.0.358276418714.issue3367@psf.upfronthosting.co.za>
In-reply-to
Content
I don't quite understand what you're saying about line mismatch Victor.
Anyway, if you look at it, it is clear that:
1) sys_update_path() can be called with argc==0 (main.c line 647)
2) 1742 was always setting arg0 to argv[0] that is undefined and this access may cause a crash if 1) above is true
3) line 1812 assumes n to be equal to the length of arg0, but depending on conditional compilation, it may not get set at all, and in any case, in line line 1805 it gets set only if p is not NULL.

I think it is simply safer to make the proper assumptions.
History
Date User Action Args
2012-03-26 09:54:52kristjan.jonssonsetrecipients: + kristjan.jonsson, loewis, akuchling, brett.cannon, georg.brandl, belopolsky, vstinner, ajaksu2, benjamin.peterson, skrah, meador.inge
2012-03-26 09:54:52kristjan.jonssonsetmessageid: <1332755692.44.0.358276418714.issue3367@psf.upfronthosting.co.za>
2012-03-26 09:54:51kristjan.jonssonlinkissue3367 messages
2012-03-26 09:54:51kristjan.jonssoncreate