Author jeffr@livedata.com
Recipients amaury.forgeotdarc, benjamin.peterson, georg.brandl, jeffr@livedata.com, pitrou, python-dev, skrah
Date 2012-03-22.17:50:29
SpamBayes Score 1.47743e-12
Marked as misclassified No
Message-id <1332438630.58.0.594774990883.issue14387@psf.upfronthosting.co.za>
In-reply-to
Content
The easiest fix would be to rename the "small" field in accu.h (and of course in any file that references that field.)  I have no idea who uses this file.

Perhaps the 2nd easiest fix would be to put this after the #include of Windows.h

#ifdef small
#undef small
#endif

As long as any extension also including Windows.h included Windows.h BEFORE Python.h, this should fix the problem for an extension builder.

A further thought is to put

#define WIN32_LEAN_AND_MEAN

right before the #include Windows.h

This doesn't fix the extension problem in that every #include of Windows.h would need to do this (SQLITE doesn't right now) but if all Python needs from Windows.h is in the "WIN32_LEAN_AND_MEAN" subset, it seems like a good thing in general, no?
History
Date User Action Args
2012-03-22 17:50:30jeffr@livedata.comsetrecipients: + jeffr@livedata.com, georg.brandl, amaury.forgeotdarc, pitrou, benjamin.peterson, skrah, python-dev
2012-03-22 17:50:30jeffr@livedata.comsetmessageid: <1332438630.58.0.594774990883.issue14387@psf.upfronthosting.co.za>
2012-03-22 17:50:30jeffr@livedata.comlinkissue14387 messages
2012-03-22 17:50:29jeffr@livedata.comcreate