Message155881
> I notice that your logging test code doesn't override create_socket. Is that no longer needed?
I removed that code from test_logging, but the code in the BitBucket repo shows how I'd like smtpd to be changed.
I would of course prefer to avoid copying stuff from SMTPChannel, as the docstring for TestSMTPChannel indicates. If you could take a look at the suggested changes in
https://bitbucket.org/vinay.sajip/cpython-smtpd/compare/default..mirror/cpython
and let me have your comments, that'd be great. The code in that repo does redefine create_socket. |
|
Date |
User |
Action |
Args |
2012-03-15 12:14:54 | vinay.sajip | set | recipients:
+ vinay.sajip, terry.reedy, giampaolo.rodola, r.david.murray |
2012-03-15 12:14:54 | vinay.sajip | set | messageid: <1331813694.31.0.989706241188.issue11959@psf.upfronthosting.co.za> |
2012-03-15 12:14:53 | vinay.sajip | link | issue11959 messages |
2012-03-15 12:14:53 | vinay.sajip | create | |
|