Author eric.araujo
Recipients alexis, eric.araujo, tarek, vinay.sajip
Date 2012-02-19.06:20:32
SpamBayes Score 5.78131e-11
Marked as misclassified No
Message-id <1329632434.39.0.0734457312276.issue12393@psf.upfronthosting.co.za>
In-reply-to
Content
I’ve had a look at your implementation.  It is an interesting use of properties, but doesn’t quite fit into how packaging works.  Most of the options parsing and validation (from config files and command-line alike) is done in each command’s finalize_options method, some parsing and validation is done in the config module (for the metadata, files and soon extension sections), and the section named “global” is validated by the Distribution (or maybe Dispatcher now) class.  So I’ll certainly reuse your tests, but will have to redo the implementation.

I’m also wondering if install_data’s options are the right place for this.  For example, does it make sense to allow “pysetup run install_data --categories spam=blah”?  (Any command option can be given on the command line.)  Maybe the global section of setup.cfg would be better.
History
Date User Action Args
2012-02-19 06:20:34eric.araujosetrecipients: + eric.araujo, vinay.sajip, tarek, alexis
2012-02-19 06:20:34eric.araujosetmessageid: <1329632434.39.0.0734457312276.issue12393@psf.upfronthosting.co.za>
2012-02-19 06:20:33eric.araujolinkissue12393 messages
2012-02-19 06:20:32eric.araujocreate