Message153140
On Fri, 2012-02-10 at 23:02 +0000, STINNER Victor wrote:
> STINNER Victor <victor.stinner@haypocalc.com> added the comment:
>
> Review of add-randomization-(...).patch:
> - there is a missing ")" in the doc, near "the types covered by the :option:`-R` option (or its equivalent, :envvar:`PYTHONHASHRANDOMIZATION`."
> - get_hash() in test_hash.py fails completly on Windows: Windows requires some environment variables. Just use env=os.environ.copy() instead of env={}.
> - PYTHONHASHSEED doc is not clear: it should be mentionned that the variable is ignored if PYTHONHASHRANDOMIZATION is not set
> - (Python 2.6) test_hash fails because of "[xxx refs]" in stderr if Python is compiled in debug mode. Add strip_python_stderr() to test_support.py and use it in get_hash().
I'm attaching revised versions of the "add-randomization" patches
incorporating review feedback:
add-randomization-to-2.6-dmalcolm-2012-02-11-001.patch
add-randomization-to-3.1-dmalcolm-2012-02-11-001.patch
The other pair of patches are unchanged from before:
fix-broken-tests-on-2.6-dmalcolm-2012-02-06-001.patch
fix-broken-tests-on-3.1-dmalcolm-2012-02-06-001.patch
Changes relative to *-2012-02-06-001.patch:
* changed the wording of the docs relating to PYTHONHASHSEED in
Doc/using/cmdline.rst to:
* clarify the interaction with PYTHONHASHRANDOMIZATION and -R
* mentioning another possible use case: "to allow a cluster of
python processes to share hash values." (as per
http://bugs.python.org/issue13703#msg152344 )
* rewording the awkward "overrides the other setting"
* I've added a description of PYTHONHASHSEED back to the man page and
to the --help text
* grammar fixes for "Fail to" in 2.6 version of the patch (were
already fixed in 3.1)
* restored __VMS randomization, by porting vms_urandom from
Modules/posixmodule.c to Python/random.c (though I have no way of
testing this)
* changed env = {} to env = os.environ.copy() in get_hash() as noted
by haypo
* fixed test_hash --with-pydebug as noted by haypo (and test_os),
adding strip_python_stderr from 2.7
I haven't enabled randomization in the Makefile.pre.in |
|
Date |
User |
Action |
Args |
2012-02-11 23:06:28 | dmalcolm | set | recipients:
+ dmalcolm, lemburg, gvanrossum, tim.peters, loewis, barry, georg.brandl, terry.reedy, gregory.p.smith, jcea, mark.dickinson, pitrou, vstinner, christian.heimes, benjamin.peterson, eric.araujo, grahamd, Arfrever, v+python, alex, zbysz, skrah, gz, neologix, Arach, Mark.Shannon, eric.snow, Zhiping.Deng, Huzaifa.Sidhpurwala, Jim.Jewett, PaulMcMillan, fx5, skorgu |
2012-02-11 23:06:24 | dmalcolm | link | issue13703 messages |
2012-02-11 23:06:24 | dmalcolm | create | |
|