Author neologix
Recipients BreamoreBoy, gearb0x, jnoller, neologix, news1234, pitrou
Date 2012-02-04.12:58:49
SpamBayes Score 3.572e-10
Marked as misclassified No
Message-id <CAH_1eM2m-Z5r=8cZLU8g67p7ssQVapbaUG43Pu4CHNm=b7W3jw@mail.gmail.com>
In-reply-to <1326308937.3531.24.camel@localhost.localdomain>
Content
> Well it would probably be closed when the connection object is
> destroyed, but the patch looks ok anyway.

Let's be nice with those non refcount-based implementations out there :-)

What do you think of the patch attached
(connection_multiple_bind-1.diff) for the original problem?
It does two things:
1. add the FILE_FLAG_FIRST_PIPE_INSTANCE when creating a pipe on Windows
2. remove SO_REUSEADDR altogether on Windows, since it doesn't seem to
be required

For 2, it should be correct if I understand Microsoft's documentation
correctly, but then I wonder why test.support goes through the pain of
using SO_REUSEADDR + SO_EXCLUSIVEADDRUSE instead of just dropping
SO_REUSEADDR. Do you happen to know a Windows guru (or maybe should I
ask on python-dev?).
Files
File name Uploaded
connection_multiple_bind-1.diff neologix, 2012-02-04.12:58:48
History
Date User Action Args
2012-02-04 12:58:50neologixsetrecipients: + neologix, pitrou, jnoller, news1234, BreamoreBoy, gearb0x
2012-02-04 12:58:49neologixlinkissue8184 messages
2012-02-04 12:58:49neologixcreate