Author vstinner
Recipients Arfrever, amaury.forgeotdarc, denilsonsa, eric.araujo, giampaolo.rodola, loewis, neologix, pitrou, rosslagerwall, vstinner, zbysz
Date 2012-01-21.13:57:36
SpamBayes Score 4.86313e-07
Marked as misclassified No
Message-id <1327154257.69.0.829737696328.issue13609@psf.upfronthosting.co.za>
In-reply-to
Content
> Does this need need more discussion, code review, testing,
> or just more time?

As I already wrote, I would prefer a very simple os.get_terminal_size() function: don't read environment varaiables, use a simple tuple instead of a new type, and raise an error if the size cannot be read (so no need of default values). The os module is written as a thin wrapper between Python and the OS. A more high level function (read environment variables, handle the error, use a namedtuple) can be written in your application, or maybe in another module.

This is just my opinion, other core developers may prefer your version :-)
History
Date User Action Args
2012-01-21 13:57:37vstinnersetrecipients: + vstinner, loewis, amaury.forgeotdarc, pitrou, giampaolo.rodola, eric.araujo, Arfrever, zbysz, denilsonsa, neologix, rosslagerwall
2012-01-21 13:57:37vstinnersetmessageid: <1327154257.69.0.829737696328.issue13609@psf.upfronthosting.co.za>
2012-01-21 13:57:36vstinnerlinkissue13609 messages
2012-01-21 13:57:36vstinnercreate