Message150899
> For some reason, the second changeset broke the OpenIndiana buildbots:
>
I have absolutely no idea of why this doesn't work. I suspect
rewinddir() is a noop on OpenIndiana if readdir() hasn't been called.
I'll revert this commit.
> Also, wouldn't it be better to call rewinddir with the GIL released?
> (although I agree rewinddir shouldn't be expensive)
rewinddir() just changes a pointer, and calls - or ought to call -
lseek() on the FD. This should be fast, since no I/O is involved
(lseek() is not documented to return EINTR, for example). Releasing
the GIL has a cost :-) |
|
Date |
User |
Action |
Args |
2012-01-08 19:32:12 | neologix | set | recipients:
+ neologix, pitrou, rosslagerwall, python-dev |
2012-01-08 19:29:03 | neologix | link | issue13739 messages |
2012-01-08 19:29:03 | neologix | create | |
|