Message150732
Some remarks on the Windows implementation in termsize.diff.4:
- On Windows, the C runtime always sets fileno(stdout) to 1, so hardcoded values are OK.
But on Unix, I'm quite sure that embedded interpreters (mod_python?) sometimes close the standard descriptor, so fd=1 can refer to something entirely different.
Does it makes sense to initialize fd=fileno(stdout) (this is C code) instead?
- When GetStdHandle() returns INVALID_HANDLE_VALUE, PyErr_SetFromWindowsErr(0) should be used.
And it's not necessary to use GetLastError(), 0 is enough.
- GetStdHandle will return NULL in a non-console application (try with pythonw.exe or IDLE), I think a specific error message should be raised in this case. |
|
Date |
User |
Action |
Args |
2012-01-06 13:44:57 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, loewis, pitrou, vstinner, giampaolo.rodola, Arfrever, zbysz, denilsonsa, neologix, rosslagerwall |
2012-01-06 13:44:57 | amaury.forgeotdarc | set | messageid: <1325857497.66.0.387909902654.issue13609@psf.upfronthosting.co.za> |
2012-01-06 13:44:57 | amaury.forgeotdarc | link | issue13609 messages |
2012-01-06 13:44:56 | amaury.forgeotdarc | create | |
|