Author zbysz
Recipients amaury.forgeotdarc, denilsonsa, giampaolo.rodola, pitrou, zbysz
Date 2011-12-17.01:41:29
SpamBayes Score 2.79618e-10
Marked as misclassified No
Message-id <1324086093.88.0.473648211956.issue13609@psf.upfronthosting.co.za>
In-reply-to
Content
Here's updated version: termsize.diff.1

> Ok, a couple of general comments:
> - there is no point having a separate module for a single function; I > think the os module (and posixmodule.c for the C side) is a
> reasonable place where to put this
Done. (But posixmodule.c is so enourmous... I feel bad making it even longer.)

> - C code should be indented with 4 spaces increments and no tabs (see > PEP 7)
> - constants in C code should be uppercase
> - C code should be C89-compliant and therefore we don't use named
> struct initializers (such as ".m_size = 0")
All done, I hope.

This version was tested on linux/amd64 and win32 (XP).
History
Date User Action Args
2011-12-17 01:41:34zbyszsetrecipients: + zbysz, amaury.forgeotdarc, pitrou, giampaolo.rodola, denilsonsa
2011-12-17 01:41:33zbyszsetmessageid: <1324086093.88.0.473648211956.issue13609@psf.upfronthosting.co.za>
2011-12-17 01:41:33zbyszlinkissue13609 messages
2011-12-17 01:41:32zbyszcreate