Message149653
Here's updated version: termsize.diff.1
> Ok, a couple of general comments:
> - there is no point having a separate module for a single function; I > think the os module (and posixmodule.c for the C side) is a
> reasonable place where to put this
Done. (But posixmodule.c is so enourmous... I feel bad making it even longer.)
> - C code should be indented with 4 spaces increments and no tabs (see > PEP 7)
> - constants in C code should be uppercase
> - C code should be C89-compliant and therefore we don't use named
> struct initializers (such as ".m_size = 0")
All done, I hope.
This version was tested on linux/amd64 and win32 (XP). |
|
Date |
User |
Action |
Args |
2011-12-17 01:41:34 | zbysz | set | recipients:
+ zbysz, amaury.forgeotdarc, pitrou, giampaolo.rodola, denilsonsa |
2011-12-17 01:41:33 | zbysz | set | messageid: <1324086093.88.0.473648211956.issue13609@psf.upfronthosting.co.za> |
2011-12-17 01:41:33 | zbysz | link | issue13609 messages |
2011-12-17 01:41:32 | zbysz | create | |
|