Author pitrou
Recipients amaury.forgeotdarc, denilsonsa, giampaolo.rodola, pitrou, zbysz
Date 2011-12-16.17:32:03
SpamBayes Score 1.6821e-08
Marked as misclassified No
Message-id <1324056723.82.0.244104141843.issue13609@psf.upfronthosting.co.za>
In-reply-to
Content
Ok, a couple of general comments:
- there is no point having a separate module for a single function; I think the os module (and posixmodule.c for the C side) is a reasonable place where to put this
- C code should be indented with 4 spaces increments and no tabs (see PEP 7)
- constants in C code should be uppercase
- C code should be C89-compliant and therefore we don't use named struct initializers (such as ".m_size = 0")
History
Date User Action Args
2011-12-16 17:32:03pitrousetrecipients: + pitrou, amaury.forgeotdarc, giampaolo.rodola, zbysz, denilsonsa
2011-12-16 17:32:03pitrousetmessageid: <1324056723.82.0.244104141843.issue13609@psf.upfronthosting.co.za>
2011-12-16 17:32:03pitroulinkissue13609 messages
2011-12-16 17:32:03pitroucreate