Author bethard
Recipients arnau, bethard, eric.araujo, flying sheep
Date 2011-12-15.10:47:29
SpamBayes Score 4.15216e-05
Marked as misclassified No
Message-id <1323946050.49.0.0302398325776.issue12776@psf.upfronthosting.co.za>
In-reply-to
Content
Could you add a test to verify that custom actions are still getting the converted values passed to their __call__? I suspect this may not be happening under the current patch - if that's the case, you may also need to add conversions in _get_values, where the lines look like "value = action.default".

Also, "action.default == getattr(namespace, action.dest)" should probably use "is" instead of "==".

Other than that, the patch looks okay.
History
Date User Action Args
2011-12-15 10:47:30bethardsetrecipients: + bethard, eric.araujo, arnau, flying sheep
2011-12-15 10:47:30bethardsetmessageid: <1323946050.49.0.0302398325776.issue12776@psf.upfronthosting.co.za>
2011-12-15 10:47:29bethardlinkissue12776 messages
2011-12-15 10:47:29bethardcreate