Message149286
Ok, a couple of further (minor) issues:
- I don't think AssertionError is the right exception type. TypeError should be used when a type mismatches (e.g. "not an unicode object");
- you don't need to check for d_type being NULL, since other methods don't;
- if type_qualname == NULL, the original error should be retained.
Otherwise, looks good, thank you. |
|
Date |
User |
Action |
Args |
2011-12-12 11:05:58 | pitrou | set | recipients:
+ pitrou, jcea, meador.inge, sbt |
2011-12-12 11:05:58 | pitrou | set | messageid: <1323687958.63.0.231909332744.issue13577@psf.upfronthosting.co.za> |
2011-12-12 11:05:58 | pitrou | link | issue13577 messages |
2011-12-12 11:05:57 | pitrou | create | |
|