This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients jcea, meador.inge, pitrou, sbt
Date 2011-12-12.11:05:57
SpamBayes Score 1.90123e-06
Marked as misclassified No
Message-id <1323687958.63.0.231909332744.issue13577@psf.upfronthosting.co.za>
In-reply-to
Content
Ok, a couple of further (minor) issues:
- I don't think AssertionError is the right exception type. TypeError should be used when a type mismatches (e.g. "not an unicode object");
- you don't need to check for d_type being NULL, since other methods don't;
- if type_qualname == NULL, the original error should be retained.

Otherwise, looks good, thank you.
History
Date User Action Args
2011-12-12 11:05:58pitrousetrecipients: + pitrou, jcea, meador.inge, sbt
2011-12-12 11:05:58pitrousetmessageid: <1323687958.63.0.231909332744.issue13577@psf.upfronthosting.co.za>
2011-12-12 11:05:58pitroulinkissue13577 messages
2011-12-12 11:05:57pitroucreate