Author meador.inge
Recipients Ramchandra Apte, eric.araujo, gruszczy, meador.inge, ncoghlan, rhettinger
Date 2011-12-12.01:28:29
SpamBayes Score 3.34721e-06
Marked as misclassified No
Message-id <CAK1QoorgdM+LAzNJG-4TrRfkN_u+Qe9pBJ4WeVOz1Aoijp5p0g@mail.gmail.com>
In-reply-to <1323600170.82.0.945222018753.issue13544@psf.upfronthosting.co.za>
Content
On Sun, Dec 11, 2011 at 4:42 AM, Nick Coghlan <report@bugs.python.org> wrote:

> Explicitly spelling out __qualname__ like that makes the tests a bit too sensitive to otherwise irrelevant details of the test layout.
>
> I suggest using comparisons like "self.assertEqual(wrapper.__qualname__, f.__qualname__)" and "self.assertNotEqual(wrapper.__qualname__,
> f.__qualname__)" to make sure they're the same or different as appropriate, without caring about their precise value (this is similar to what the tests
> already do for "dict_attr")

Good point.  I will commit Filip's latest patch that has these fixes.
History
Date User Action Args
2011-12-12 01:28:30meador.ingesetrecipients: + meador.inge, rhettinger, ncoghlan, eric.araujo, gruszczy, Ramchandra Apte
2011-12-12 01:28:29meador.ingelinkissue13544 messages
2011-12-12 01:28:29meador.ingecreate