Message148303
I have had a look at the issue more closely and my initial patch was not completely right as it didn't work properly with argparse_test.py despite all tests passing.
Therefore, I have amended my patch to not check whether action.default was a basestring which didn't make sense at all, but check instead if action.default is None (action.default default value is None if not given to add_argument as far as I understand). I also added a test for the issue reported above as it was missing and ran patchcheck to make sure everything was fine. All the tests (include argparse_test.py) passes without problem.
Could you please apply them? Many thanks. |
|
Date |
User |
Action |
Args |
2011-11-25 05:34:55 | arnau | set | recipients:
+ arnau, bethard, eric.araujo, flying sheep |
2011-11-25 05:34:55 | arnau | set | messageid: <1322199295.66.0.435647115762.issue12776@psf.upfronthosting.co.za> |
2011-11-25 05:34:55 | arnau | link | issue12776 messages |
2011-11-25 05:34:54 | arnau | create | |
|