Message147042
I think this thread is becoming a little messy and since asyncore/asynchat are in a situation where even the slightest change can break existent code I recommend to be really careful.
I see 3 different issues here:
1 - dispatcher_with_send closing the socket without sending pending data (this was the initial issue)
2 - dispatcher_with_send default buffer is too small (512 bytes)
3 - add support for correct POLLHUP/socket.shutdown() handling (msg146946)
All of them should be treated and discussed separately in their own ticket to figure out:
- what's wrong
- whether it's a bugfix or a new feature (POLLHUP handling appears to be so)
- for what python version(s) the patch should be applied
As a final note we should consider mandatory for any patch not to alter the existent API.
initiate_send() method suddenly returning a meaningful value might be the case and as such it should be weighed up first. |
|
Date |
User |
Action |
Args |
2011-11-04 21:27:10 | giampaolo.rodola | set | recipients:
+ giampaolo.rodola, josiahcarlson, stutzbach, neologix, xdegaye, François-Xavier.Bourlet |
2011-11-04 21:27:10 | giampaolo.rodola | set | messageid: <1320442030.6.0.385641318285.issue12498@psf.upfronthosting.co.za> |
2011-11-04 21:27:10 | giampaolo.rodola | link | issue12498 messages |
2011-11-04 21:27:09 | giampaolo.rodola | create | |
|