Message 146706 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	eric.araujo
Recipients	RonnyPfannschmidt, alexis, eric.araujo, jens, mikehoy, mu_mind, tarek
Date	2011-10-31.16:22:46
SpamBayes Score	9.808121e-08
Marked as misclassified	No
Message-id	<1320078166.97.0.78225774942.issue11638@psf.upfronthosting.co.za>
In-reply-to

Content
> Here's a test for the bug. Thanks! Some comments are strange, but the patch is a good start. > One way to fix the symptom (maybe not the correct way) would be to edit > tarfile._Stream._init_write_gz I’d rather change distutils, not tarfile. I think the best place to encode it may be in the cmd module (see the make_archive method). > I'm not positive UTF-8 is right It is. > and maybe it should only convert if isinstance(self.name, unicode). Indeed.

> Here's a test for the bug.
Thanks!  Some comments are strange, but the patch is a good start.

> One way to fix the symptom (maybe not the correct way) would be to edit
> tarfile._Stream._init_write_gz
I’d rather change distutils, not tarfile.  I think the best place to encode it may be in the cmd module (see the make_archive method).

> I'm not positive UTF-8 is right
It is.

> and maybe it should only convert if isinstance(self.name, unicode).
Indeed.

History
Date	User	Action	Args
2011-10-31 16:22:47	eric.araujo	set	recipients: + eric.araujo, tarek, RonnyPfannschmidt, alexis, mu_mind, mikehoy, jens
2011-10-31 16:22:46	eric.araujo	set	messageid: <1320078166.97.0.78225774942.issue11638@psf.upfronthosting.co.za>
2011-10-31 16:22:46	eric.araujo	link	issue11638 messages
2011-10-31 16:22:46	eric.araujo	create