Author eric.araujo
Recipients alexis, eric.araujo, paul.moore, tarek, vinay.sajip
Date 2011-10-17.16:12:12
SpamBayes Score 5.57927e-07
Marked as misclassified No
Message-id <1318867933.42.0.579952832378.issue13175@psf.upfronthosting.co.za>
In-reply-to
Content
>>> The file passed to csv.writer should be opened with newline=''.
>> How will we port this to 2.x?
> No idea :-( The 2.7 documentation says use the 'b' flag, but that
> probably doesn't allow an encoding parameter (it doesn't on 3.x).

Ah, I see that newline controls newline translation.  We use codecs.open in distutils2; I think it uses universal newlines mode.  We’ll figure it out, the important part is to have good tests.

> The test fails before the fix, passes after. It's a no-op on platforms
> where text and binary files are the same, (i.e., non-Windows systems).
> So it's harmless.

Great.  I’ll look at your patch and try to port it to distutils2.
History
Date User Action Args
2011-10-17 16:12:13eric.araujosetrecipients: + eric.araujo, paul.moore, vinay.sajip, tarek, alexis
2011-10-17 16:12:13eric.araujosetmessageid: <1318867933.42.0.579952832378.issue13175@psf.upfronthosting.co.za>
2011-10-17 16:12:12eric.araujolinkissue13175 messages
2011-10-17 16:12:12eric.araujocreate