Message145454
> I think the >1 character sizes are overly complex in this patch, and
> still memchr isn't typically used for them. So I suggest to simplify
> the code and restrict it to 1-byte chars only.
I would rather propose to simplify the needle heuristic and only use it
when the lower byte is non-zero. A properly optimized memchr() (as in
the glibc / gcc) is definitely faster than our naïve loop. |
|
Date |
User |
Action |
Args |
2011-10-13 14:21:13 | pitrou | set | recipients:
+ pitrou, lemburg, loewis, vstinner, python-dev |
2011-10-13 14:21:12 | pitrou | link | issue13134 messages |
2011-10-13 14:21:12 | pitrou | create | |
|