This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mhammond
Recipients Garen, John.Cary, abenard, alexis, cgohlke, eric.araujo, eric.smith, koen, loewis, mhammond, tarek, techtonik
Date 2011-10-09.04:12:05
SpamBayes Score 1.3091195e-12
Marked as misclassified No
Message-id <>
Thanks for the review.  One note:

| +    def manifest_setup_ldargs
| I’d make all new methods private ones (i.e. leading underscore).

They aren't strictly private and are designed to be overridden by subclasses (although in practice, subclassing the compiler is much harder than it should be, so pywin32 monkey-patches the instance.)  This is actually the entire point of my updated patch - to give authors some level of control over the manifest behaviour.

I do intend forward-porting to 3.3 and also to check it is is too late for 3.2 (a quick check before implied it might be OK, but I'm not sure)
Date User Action Args
2011-10-09 04:12:06mhammondsetrecipients: + mhammond, loewis, eric.smith, techtonik, koen, tarek, eric.araujo, cgohlke, Garen, alexis, John.Cary, abenard
2011-10-09 04:12:06mhammondsetmessageid: <>
2011-10-09 04:12:05mhammondlinkissue7833 messages
2011-10-09 04:12:05mhammondcreate