Author eric.araujo
Recipients eric.araujo, hynek, mrts, petri.lehtinen, pitrou, rosslagerwall, schmir, tarek, teamnoir
Date 2011-10-07.17:35:39
SpamBayes Score 0.0543424
Marked as misclassified No
Message-id <1318008940.09.0.903739508634.issue4489@psf.upfronthosting.co.za>
In-reply-to
Content
I made another review but my mail was rejected.

http://bugs.python.org/review/4489/diff/3383/10563#newcode319
Lib/test/test_shutil.py:319: @unittest.skipIf(threading == None,
'requires threading')
You can just say skipUnless(threading, 'msg')

http://bugs.python.org/review/4489/diff/3383/10563#newcode344
Lib/test/test_shutil.py:344: raise
Shouldn’t this use self.fail?
History
Date User Action Args
2011-10-07 17:35:40eric.araujosetrecipients: + eric.araujo, pitrou, schmir, tarek, mrts, teamnoir, rosslagerwall, petri.lehtinen, hynek
2011-10-07 17:35:40eric.araujosetmessageid: <1318008940.09.0.903739508634.issue4489@psf.upfronthosting.co.za>
2011-10-07 17:35:39eric.araujolinkissue4489 messages
2011-10-07 17:35:39eric.araujocreate