Message 144309 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	baikie
Recipients	baikie, neologix, vstinner
Date	2011-09-19.19:30:17
SpamBayes Score	3.661064e-07
Marked as misclassified	No
Message-id	<20110919193016.GA5038@dbwatson.ukfsn.org>
In-reply-to	<1316380300.83.0.142812104939.issue12981@psf.upfronthosting.co.za>

Content
On Sun 18 Sep 2011, Charles-François Natali wrote: > > I had a look at this patch, and the FD passing looked OK, except > > that calculating the buffer size with CMSG_SPACE() may allow more > > than one file descriptor to be received, with the extra one going > > unnoticed - it should use CMSG_LEN() instead > > > (the existing C implementation has the same problem, I see). > > I just checked, and the C version uses CMSG_SPACE() as the buffer size, but passes CMSG_LEN() to cmsg->cmsg_len and msg.msg_controllen. Or am I missing something? Ah, no, you're right - that's fine. Sorry for the false alarm.

On Sun 18 Sep 2011, Charles-François Natali wrote:
> > I had a look at this patch, and the FD passing looked OK, except
> > that calculating the buffer size with CMSG_SPACE() may allow more
> > than one file descriptor to be received, with the extra one going
> > unnoticed - it should use CMSG_LEN() instead
> 
> > (the existing C implementation has the same problem, I see).
> 
> I just checked, and the C version uses CMSG_SPACE() as the buffer size, but passes CMSG_LEN() to cmsg->cmsg_len and msg.msg_controllen. Or am I missing something?

Ah, no, you're right - that's fine.  Sorry for the false alarm.

History
Date	User	Action	Args
2011-09-19 19:30:18	baikie	set	recipients: + baikie, vstinner, neologix
2011-09-19 19:30:17	baikie	link	issue12981 messages
2011-09-19 19:30:17	baikie	create