This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.snow
Recipients daniel.urban, eric.snow
Date 2011-08-31.04:43:50
SpamBayes Score 0.000283958
Marked as misclassified No
Message-id <1314765831.62.0.550647624779.issue12857@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the review, Nick.  I'll be uploading a new patch in a couple hours with your recommended fixes.

Regarding the comments on python-ideas, would it be better to use a weakref proxy around the function, to help with the reference cycles?  That's what I was doing with my closure-based solution.  I didn't do it here just to see what would happen and I didn't see any problems in my very limited testing (basically just 'make test').  I don't mind using weakrefs and, if it matters, I could pre-allocate the weakref proxy in PyFunction_New to save a little overhead at each call. 

For the moment I left in the code to limit f_func to only functions.  I'll respond to that on python-ideas.

Finally, how does this patch relate to the ABI?  I'm not too familiar with it (read through PEP 384) and want to make sure I'm okay here.
History
Date User Action Args
2011-08-31 04:43:51eric.snowsetrecipients: + eric.snow, daniel.urban
2011-08-31 04:43:51eric.snowsetmessageid: <1314765831.62.0.550647624779.issue12857@psf.upfronthosting.co.za>
2011-08-31 04:43:51eric.snowlinkissue12857 messages
2011-08-31 04:43:50eric.snowcreate