Message140020
Excellent! I will apply this.
> I looked through the rest of database.py and did not see any other
> generators that appeared to erroneously hold a file handle open.
Me neither. Thanks for checking.
> In addition there is one generator function (list_distinfo_files)
> which feeds off of the generator I have changed but I didn't see a
> need to alter them as they work fine as generators.
I think using a generator can save some memory, if the underlying list is huge, but the important thing here is that all functions with a similar name (list_*) behave in a consistent way, i.e. returning lists or generators but not a mix. |
|
Date |
User |
Action |
Args |
2011-07-08 11:19:16 | eric.araujo | set | recipients:
+ eric.araujo, tarek, thomas.holmes, alexis |
2011-07-08 11:19:16 | eric.araujo | set | messageid: <1310123956.13.0.293905620456.issue12504@psf.upfronthosting.co.za> |
2011-07-08 11:19:15 | eric.araujo | link | issue12504 messages |
2011-07-08 11:19:15 | eric.araujo | create | |
|