This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.araujo
Recipients alexis, eli.collins, eric.araujo, tarek
Date 2011-06-24.11:20:34
SpamBayes Score 2.9132675e-06
Marked as misclassified No
Message-id <1308914435.02.0.359886769633.issue12242@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks!

> This patch was made against the hg.python.org/cpython repo.
This is good.  See http://wiki.python.org/moin/Distutils/Contributing

> I'm not sure where I should add documentation about this new behavior.
At least in Doc/library/packaging.compiler.rst and Doc/packaging/setupcfg.rst, maybe in Doc/install too.

> This feature could probably use some unittests to be added as well.
Yes.  You can see how we use mocking in test_unixccompiler.py or test_util.py to test real-world program output and make sure our code parses it right.

> This doesn't seem right to me, as "--" is frequently found in options
> strings, and I'd expect it to cause problems.  If this is a bug in
> extra_compile_args, I'm happy to create a separate bug and submit a patch.
Please do.  I’ll look into the history to see whether there was a comment about that, but this really looks like a bug.  The separator should be something that can’t be part of options strings, like “;”.
History
Date User Action Args
2011-06-24 11:20:35eric.araujosetrecipients: + eric.araujo, tarek, alexis, eli.collins
2011-06-24 11:20:35eric.araujosetmessageid: <1308914435.02.0.359886769633.issue12242@psf.upfronthosting.co.za>
2011-06-24 11:20:34eric.araujolinkissue12242 messages
2011-06-24 11:20:34eric.araujocreate