Author eric.araujo
Recipients eric.araujo, eric.smith, giampaolo.rodola, gregory.p.smith, ncoghlan, neologix, petri.lehtinen, sandro.tosi, vstinner
Date 2011-06-24.10:51:36
SpamBayes Score 2.71606e-05
Marked as misclassified No
Message-id <1308912697.78.0.804709227855.issue12191@psf.upfronthosting.co.za>
In-reply-to
Content
haypo, you missed this comment from gps on Rietveld:

> As for the _user = user stuff, the reason that is being done is so
> that the original user and or group value can be included in the
> raised exception error message.  That is actually a nice thing to do.
> 
> otherwise, yes, i'd normally just reassign the parameters.
>
> At this point I believe this patch is ready to commit.  I'd reword
> the docstring to make it simpler but that is a minor detail and
> something that is easy to change in a future commit.

I agree the patch is ready.
History
Date User Action Args
2011-06-24 10:51:37eric.araujosetrecipients: + eric.araujo, gregory.p.smith, ncoghlan, vstinner, eric.smith, giampaolo.rodola, sandro.tosi, neologix, petri.lehtinen
2011-06-24 10:51:37eric.araujosetmessageid: <1308912697.78.0.804709227855.issue12191@psf.upfronthosting.co.za>
2011-06-24 10:51:37eric.araujolinkissue12191 messages
2011-06-24 10:51:36eric.araujocreate