Message138224
The patches look good to me, except that instead of passing
(addrlen > buflen) ? buflen : addrlen
as addrlen argument every time makesockaddr is called, I'd prefer if this min was done inside makesockaddr itself, i.e. perform min(addrlen, sizeof(struct sockaddr_un)) in the AF_UNIX switch case (especially since addrlen is only used for AF_UNIX).
Also, this would be the occasion to put a short explanatory comment (possibility of non NULL-terminated sun_path and unreliable length returned by syscalls). |
|
Date |
User |
Action |
Args |
2011-06-12 22:37:35 | neologix | set | recipients:
+ neologix, loewis, terry.reedy, pitrou, vstinner, baikie, rosslagerwall |
2011-06-12 22:37:35 | neologix | set | messageid: <1307918255.48.0.510314783448.issue8372@psf.upfronthosting.co.za> |
2011-06-12 22:37:34 | neologix | link | issue8372 messages |
2011-06-12 22:37:34 | neologix | create | |
|