Message138111
Good idea, and thanks for posting a patch! This is a new feature, so 3.3-only. Also, you'll need to update the docs (Doc/library/zlib.rst, presumably) to add the new module method/attribute (with a suitable "versionadded" tag).
Nitpicking:
- "zlibVersion" isn't PEP8-compliant
- semantically it should probably be a module-level attribute, rather than a method; after all it's kind of a constant; perhaps ZLIB_RUNTIME_VERSION?
Also, I see that ZLIB_VERSION itself isn't documented, it would be nice to have a separate patch to fix that. |
|
Date |
User |
Action |
Args |
2011-06-10 16:57:33 | pitrou | set | recipients:
+ pitrou, nadeem.vawda, torsten |
2011-06-10 16:57:33 | pitrou | set | messageid: <1307725053.66.0.343078875623.issue12306@psf.upfronthosting.co.za> |
2011-06-10 16:57:33 | pitrou | link | issue12306 messages |
2011-06-10 16:57:32 | pitrou | create | |
|