This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rhettinger
Recipients benjamin.peterson, eric.araujo, georg.brandl, lopgok, nadeem.vawda, r.david.murray, rhettinger
Date 2011-06-06.19:59:26
SpamBayes Score 2.120429e-07
Marked as misclassified No
Message-id <1307390367.38.0.705241298619.issue11802@psf.upfronthosting.co.za>
In-reply-to
Content
Nadeem, I want to review this but won't have a chance to do it right away.  Offhand, it seems like we could use the existing functools.lru_cache() for this if the stats were included as part of the key:  cache[f1, f2, s1, s2]=outcome.

Also, I want to take a fresh look at the cache strategy (saving diffs of two files vs saving file contents individually) and think about whether than makes any sense at all for real world use cases (is there a common need to compare the same file pairs over and over again or is the typical use the comparison of many different file pairs).   There may even be a better way to approach the underlying problem using hashes of entire files (md5, sha1, etc).
History
Date User Action Args
2011-06-06 19:59:27rhettingersetrecipients: + rhettinger, georg.brandl, nadeem.vawda, benjamin.peterson, eric.araujo, r.david.murray, lopgok
2011-06-06 19:59:27rhettingersetmessageid: <1307390367.38.0.705241298619.issue11802@psf.upfronthosting.co.za>
2011-06-06 19:59:26rhettingerlinkissue11802 messages
2011-06-06 19:59:26rhettingercreate