Author pitrou
Recipients pitrou, vstinner
Date 2011-05-25.12:21:27
SpamBayes Score 2.13662e-09
Marked as misclassified No
Message-id <1306326085.3580.2.camel@localhost.localdomain>
In-reply-to <1306325640.48.0.610014463103.issue12175@psf.upfronthosting.co.za>
Content
> FileIO.readall() reads the file position and size before each call to
> read(), to adjust the buffer size.
> 
> Moreover FileIO.readall() calls lseek() on Windows: it should use
> _lseeki64() instead, to handle correctly file bigger than 2 GB (or
> maybe 4 GB? I don't know).
> 
> Attached patch fixes both problems.

Looks ok to me. Did you test under Windows? Did you run some benchmarks?
History
Date User Action Args
2011-05-25 12:21:27pitrousetrecipients: + pitrou, vstinner
2011-05-25 12:21:27pitroulinkissue12175 messages
2011-05-25 12:21:27pitroucreate