Message136175
I've dropped wet-her!
I hope now you're satisfied!!!!!
So the buffer cache is all which remains hot.
How deserted!
> And you could also add a test (I guess that just calling fsync
> with full_sync=True on a valid FD would be enough.
I was able to add two tests as an extension to what is yet tested
about os.fsync(), but that uses an invalid fd.
(At least it enters the conditional and fails as expected.)
> I'm not sure static is necessary, I'd rather make it const.
Yes..
> This code is correct as it is, see other extension modules in
> the stdlib for other examples of this pattern
..but i've used copy+paste here.
> And you could also add a test (I guess that just calling fsync
> with full_sync=True on a valid FD would be enough.
> The alternative would be that full_sync
Ok, i've renamed full_fsync to full_sync. |
File name |
Uploaded |
11877.9.diff
|
sdaoden,
2011-05-17.20:17:22
|
|
Date |
User |
Action |
Args |
2011-05-17 20:17:25 | sdaoden | set | recipients:
+ sdaoden, ronaldoussoren, pitrou, vstinner, nadeem.vawda, neologix, santoso.wijaya |
2011-05-17 20:17:23 | sdaoden | link | issue11877 messages |
2011-05-17 20:17:23 | sdaoden | create | |
|