Message135847
Calling fsync on a file descriptor referring to a tty doesn't make much sense.
On Linux, this fails with EINVAL:
$ python -c 'import os; os.fsync(1)'
Traceback (most recent call last):
File "<string>", line 1, in <module>
OSError: [Errno 22] Invalid argument
So if the full sync fails on ttys, it shouldn't be a problem: since
the default performs a classical fsync, this won't break compatibility
with existing code anyway.
So I think you should stick with the previous version (well, if the
full sync fails on other FDs, then it's another story, but in that
case it should just be dropped altogether if it's not reliable...).
By the way, it's "appropriate", not "approbiate". You made the same
typo in your patch. |
|
Date |
User |
Action |
Args |
2011-05-12 18:14:37 | neologix | set | recipients:
+ neologix, ronaldoussoren, pitrou, vstinner, nadeem.vawda, santoso.wijaya, sdaoden |
2011-05-12 18:14:36 | neologix | link | issue11877 messages |
2011-05-12 18:14:36 | neologix | create | |
|