This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author neologix
Recipients nadeem.vawda, neologix, pitrou, ronaldoussoren, santoso.wijaya, sdaoden, vstinner
Date 2011-05-12.18:14:36
SpamBayes Score 8.8928864e-14
Marked as misclassified No
Message-id <BANLkTikjJbCnh9gVzEKpfZ4LjM8F0ZLhzA@mail.gmail.com>
In-reply-to <20110512104327.GA77093@sherwood.local>
Content
Calling fsync on a file descriptor referring to a tty doesn't make much sense.
On Linux, this fails with EINVAL:
$ python -c 'import os; os.fsync(1)'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
OSError: [Errno 22] Invalid argument

So if the full sync fails on ttys, it shouldn't be a problem: since
the default performs a classical fsync, this won't break compatibility
with existing code anyway.
So I think you should stick with the previous version (well, if the
full sync fails on other FDs, then it's another story, but in that
case it should just be dropped altogether if it's not reliable...).

By the way, it's "appropriate", not "approbiate". You made the same
typo in your patch.
History
Date User Action Args
2011-05-12 18:14:37neologixsetrecipients: + neologix, ronaldoussoren, pitrou, vstinner, nadeem.vawda, santoso.wijaya, sdaoden
2011-05-12 18:14:36neologixlinkissue11877 messages
2011-05-12 18:14:36neologixcreate