Author belopolsky
Recipients alexandre.vassalotti, amaury.forgeotdarc, belopolsky, janglin, pitrou, rhettinger, santoso.wijaya
Date 2011-04-26.21:47:43
SpamBayes Score 1.84952e-07
Marked as misclassified No
Message-id <1303854464.04.0.715376651777.issue9614@psf.upfronthosting.co.za>
In-reply-to
Content
> The warnings at lines 284, 301, 461, 647 are benign.

I agree.  There is no loss of data because Py_ssize_t variable bounds are checked before these lines are reached.

> The attached patch fixes them.

I don't like these changes:

-Pdata_poptuple(Pdata *self, Py_ssize_t start)
+Pdata_poptuple(Pdata *self, int start)

-Pdata_poplist(Pdata *self, Py_ssize_t start)
+Pdata_poplist(Pdata *self, int start)

These seem to attempt to fix

    Py_SIZE(self) = start;

assignments, but as far as I can tell, Py_SIZE(self) type is Py_ssize_t.

What do I miss here?
History
Date User Action Args
2011-04-26 21:47:44belopolskysetrecipients: + belopolsky, rhettinger, amaury.forgeotdarc, pitrou, alexandre.vassalotti, janglin, santoso.wijaya
2011-04-26 21:47:44belopolskysetmessageid: <1303854464.04.0.715376651777.issue9614@psf.upfronthosting.co.za>
2011-04-26 21:47:43belopolskylinkissue9614 messages
2011-04-26 21:47:43belopolskycreate