Author lemburg
Recipients benjamin.peterson, bgomes, christian.heimes, doko, draghuram, eric.araujo, georg.brandl, lemburg, pavel.vinogradov, pola, sapetnioc, zooko
Date 2011-04-21.22:02:41
SpamBayes Score 2.22045e-16
Marked as misclassified No
Message-id <4DB0A97B.3020400@egenix.com>
In-reply-to <1303398925.93.0.650776119298.issue1322@psf.upfronthosting.co.za>
Content
Éric Araujo wrote:
> 
> Éric Araujo <merwok@netwok.org> added the comment:
> 
> [Zooko]
>> I just read back through this ticket, but I didn't understand exactly
>> what MAL wanted to have different from what this Python function
>> currently does:
> 
> It may be this:
> 
>> It's better to follow the approach taken by lsb_release and then
>> add calling lsb_release as one of the methods taken by
>> _dist_try_harder() (using platform.popen()) should the parsers
>> fail.
>> This avoids spawning a process in most cases.

Indeed.

You also need to make sure that the function doesn't suddenly
return different output for setups that are supported and work
as advertised.

Note that the Debian mention in the string output is not really
incorrect, given that Ubuntu and other distros are based on the
work done by the Debian project.

Looking back, I shouldn't have added the function to begin
with and just use "Linux" in the platform string. It's causing
too much maintenance overhead.
Perhaps deprecating it altogether is more appropriate.
History
Date User Action Args
2011-04-21 22:02:41lemburgsetrecipients: + lemburg, georg.brandl, doko, zooko, draghuram, christian.heimes, sapetnioc, benjamin.peterson, pavel.vinogradov, bgomes, eric.araujo, pola
2011-04-21 22:02:41lemburglinkissue1322 messages
2011-04-21 22:02:41lemburgcreate