Author Prashant.Kumar
Recipients Prashant.Kumar, Thorsten.Simons, eric.araujo, fdrake, tarek
Date 2011-04-17.18:03:25
SpamBayes Score 0.000298837
Marked as misclassified No
Message-id <1303063406.11.0.556600234014.issue10932@psf.upfronthosting.co.za>
In-reply-to
Content
I made changes in manifest.py which can be viewed here: https://bitbucket.org/pkumar/distutils2_bugs/changeset/111c1253ea7a

I'm not sure if I should modify test_command_sdist.py for the failing tests of manifest contents(since it is mentioned not to edit). 

msg133834:
>> I don’t understand this comment: “Though, inside zip-file we get files without its parent dir, nothing changes in manifest file(should it change?)

code from test_command_sdist.py:

        zip_file = zipfile.ZipFile(join(dist_folder, 'fake-1.0.zip'))
        try:
            content = zip_file.namelist()
        finally:
            zip_file.close()
after the change as mentioned in msg127191, the value of content changed, i.e. 'fake-1.0/some/other_file.txt' was changed to 'fake-1.0/other_file.txt'.But modifications were still required for the manifest. Above change should serve the purpose, I guess.
History
Date User Action Args
2011-04-17 18:03:26Prashant.Kumarsetrecipients: + Prashant.Kumar, fdrake, tarek, eric.araujo, Thorsten.Simons
2011-04-17 18:03:26Prashant.Kumarsetmessageid: <1303063406.11.0.556600234014.issue10932@psf.upfronthosting.co.za>
2011-04-17 18:03:25Prashant.Kumarlinkissue10932 messages
2011-04-17 18:03:25Prashant.Kumarcreate