Author Eli.Stevens
Recipients Eli.Stevens, mark.dickinson, mark.wiebe
Date 2011-04-05.18:08:19
SpamBayes Score 1.31498e-10
Marked as misclassified No
Message-id <1302026900.21.0.953235106762.issue11734@psf.upfronthosting.co.za>
In-reply-to
Content
All four changes suggested via review from Mark Dickinson have been made.  One note: the else if (!(e == 0 && f == 0.0)) { change was made; this makes the Pack2 function parallel the Pack4 function slightly less.  I agree that it's cleaner this way, but I've left the original if in as a comment for comparison to Pack4.  I'll remove the comment if it's decided that it's better to be clean than parallel.

The suggested test cases were added in the v4 patch, just in case that wasn't clear.

I'm going to assume that my questions about _struct.c aren't issues unless someone explicitly says they are.

Thanks for all of the review and feedback!  :)
History
Date User Action Args
2011-04-05 18:08:20Eli.Stevenssetrecipients: + Eli.Stevens, mark.dickinson, mark.wiebe
2011-04-05 18:08:20Eli.Stevenssetmessageid: <1302026900.21.0.953235106762.issue11734@psf.upfronthosting.co.za>
2011-04-05 18:08:19Eli.Stevenslinkissue11734 messages
2011-04-05 18:08:19Eli.Stevenscreate