This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ooldham
Recipients
Date 2002-11-21.15:07:24
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=649833

A.M.  Yes. I had considered this type of change as well.
Looks good, however, I have a few comments :)

1) I LIKE the log.info modification you made...

nit pick 1) Consider renaming new variable 'zipfile' to 
something like 'haveZipModule'. Just for clarity...

nit pick 2) You left the comment lines below: 'except 
DistutilsExecError' intact, only the indentation changed... I 
removed this comment, as in my mind it no longer made 
sense, since the function now attempts zipfile module first... 
If you are going to leave it, at least re-word it...

nit pick 3) I re-worded the raise DistutilsExecError message... 
to show the true order of what it could not do - as did the 
original message.
History
Date User Action Args
2007-08-23 14:08:47adminlinkissue639118 messages
2007-08-23 14:08:47admincreate