Author nadeem.vawda
Recipients MizardX, antlong, asvetlov, eric.araujo, mdehoon, nadeem.vawda, niemeyer, pitrou, rhettinger, wrobell, xuanji
Date 2011-04-02.23:34:21
SpamBayes Score 2.10818e-07
Marked as misclassified No
Message-id <1301787262.79.0.2065758755.issue5863@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the review. I've made most of the changes you suggested, but there's
one thing I wanted to check about:

> - instead of "int(size)", use "size = size.__index__()" so as to forbid floats

The tests for readline() and readlines() expect a TypeError if size is None.
Calling size.__index__() in this case raises an AttributeError instead. Should I
change the tests to expect an AttributeError? Alternatively, something like this
would more closely match the behaviour of the old code:

    try:
        size = size.__index__()
    except AttributeError:
        raise TypeError("Integer argument expected")
History
Date User Action Args
2011-04-02 23:34:22nadeem.vawdasetrecipients: + nadeem.vawda, rhettinger, niemeyer, mdehoon, pitrou, wrobell, eric.araujo, asvetlov, MizardX, antlong, xuanji
2011-04-02 23:34:22nadeem.vawdasetmessageid: <1301787262.79.0.2065758755.issue5863@psf.upfronthosting.co.za>
2011-04-02 23:34:21nadeem.vawdalinkissue5863 messages
2011-04-02 23:34:21nadeem.vawdacreate