Author pitrou
Recipients MizardX, antlong, asvetlov, eric.araujo, mdehoon, nadeem.vawda, niemeyer, pitrou, rhettinger, wrobell, xuanji
Date 2011-04-02.18:28:50
SpamBayes Score 2.12996e-13
Marked as misclassified No
Message-id <1301768928.3494.36.camel@localhost.localdomain>
In-reply-to <1301751303.67.0.413930442474.issue5863@psf.upfronthosting.co.za>
Content
> Here is an updated patch that adds read1() to BZ2File. This should fix things
> for issue10791 from the bz2 side. I also took the opportunity to clean up
> _read_block() to be more readable. As per Martin's suggestion on python-dev, I
> put the copyright notice in the patch header, rather than in the code itself.

Thank you! A couple of comments:
- please avoid C++-style comments ("// ..."), some compilers don't like
them
- BZ2Decompressor.eof would be better as a T_BOOL than a T_INT, IMO
- BZ2Decompressor.eof should be documented as new in 3.3
- instead of using PyObject_GetBuffer(), I think it's better to call
PyArg_ParseTuple with the "y*" typecode: it makes sure it does the right
thing
- instead of "int(size)", use "size = size.__index__()" so as to forbid
floats
History
Date User Action Args
2011-04-02 18:28:51pitrousetrecipients: + pitrou, rhettinger, niemeyer, mdehoon, wrobell, nadeem.vawda, eric.araujo, asvetlov, MizardX, antlong, xuanji
2011-04-02 18:28:51pitroulinkissue5863 messages
2011-04-02 18:28:50pitroucreate