Author pitrou
Recipients Henri.Salo, barry, benjamin.peterson, georg.brandl, gvanrossum, orsenthil, pitrou, r.david.murray, serdar.dalgic, vstinner
Date 2011-03-29.16:48:32
SpamBayes Score 0.000135663
Marked as misclassified No
Message-id <1301417316.29.0.709533882768.issue11662@psf.upfronthosting.co.za>
In-reply-to
Content
I don't have a 2.5 checkout to test but the patch looks ok to me.
Under 2.7 I get a test failure, I suppose you'll have some merging work to do:

test test_urllib2 failed -- Traceback (most recent call last):
  File "/home/antoine/cpython/27/Lib/test/test_urllib2.py", line 990, in test_invalid_redirect
    MockHeaders({"location": valid_url}))
  File "/home/antoine/cpython/27/Lib/urllib2.py", line 616, in http_error_302
    return self.parent.open(new, timeout=req.timeout)
  File "/home/antoine/cpython/27/Lib/urllib2.py", line 219, in __getattr__
    raise AttributeError, attr
AttributeError: timeout
History
Date User Action Args
2011-03-29 16:48:36pitrousetrecipients: + pitrou, gvanrossum, barry, georg.brandl, orsenthil, vstinner, benjamin.peterson, r.david.murray, Henri.Salo, serdar.dalgic
2011-03-29 16:48:36pitrousetmessageid: <1301417316.29.0.709533882768.issue11662@psf.upfronthosting.co.za>
2011-03-29 16:48:32pitroulinkissue11662 messages
2011-03-29 16:48:32pitroucreate