Message132320
I implemented a basic test for the issue and an attempt for a fix.
I am not entirely sure with my implementation, specifically I would like to get comments concerning the following points:
- Is is OK that formataddr() will now check if address is ascii safe and if not it will raise a UnicodeEncodeError?
- I was not sure on the style how to append new tests to test_email.py, I just put it into the same spot where all the other formataddr() tests where, shall I put it to the end instead?
I am submitting this patch as part of my preparation for the Google Summer of Code to familiarize myself with the contribution process, any feedback on what I should do different is very welcome. |
|
Date |
User |
Action |
Args |
2011-03-27 13:44:30 | torsten.becker | set | recipients:
+ torsten.becker, barry, terry.reedy, r.david.murray |
2011-03-27 13:44:30 | torsten.becker | set | messageid: <1301233470.65.0.2509531099.issue1690608@psf.upfronthosting.co.za> |
2011-03-27 13:44:28 | torsten.becker | link | issue1690608 messages |
2011-03-27 13:44:28 | torsten.becker | create | |
|