Author markm
Recipients cgohlke, cmcqueen1975, fberger, janssen, markm, termim
Date 2011-03-27.10:37:12
SpamBayes Score 2.34385e-07
Marked as misclassified No
Message-id <1301222233.28.0.641716487615.issue7639@psf.upfronthosting.co.za>
In-reply-to
Content
For Directory.make_short() the only things which are left could be considered splitting hairs.

1. Do we need to remove '"\/:' from the file name - if these characters are there then the file name is not valid in the first place.

2. These characters '+,;=[]' should really be changed to '_' if we want to match more closely how Windows makes short names.

I can write a patch for the above if they should be fixed and either way I can add tests for this function. (the test I had for testing my own patch - almost completely pass - but the only failure was depending on point 2.)
History
Date User Action Args
2011-03-27 10:37:13markmsetrecipients: + markm, janssen, termim, cmcqueen1975, cgohlke, fberger
2011-03-27 10:37:13markmsetmessageid: <1301222233.28.0.641716487615.issue7639@psf.upfronthosting.co.za>
2011-03-27 10:37:12markmlinkissue7639 messages
2011-03-27 10:37:12markmcreate