Author pitrou
Recipients barry, benjamin.peterson, georg.brandl, gvanrossum, haypo, orsenthil, pitrou
Date 2011-03-24.15:36:27
SpamBayes Score 0.000152439
Marked as misclassified No
Message-id <1300980988.23.0.953062548334.issue11662@psf.upfronthosting.co.za>
In-reply-to
Content
Which patch should be reviewed? They seem to be different. Senthil's patch allows a redirect to ftp while Guido's doesn't.

Senthil's patch doesn't seem to fix urllib-inherited code, only urllib2- (see FancyURLopener.redirect_internal()).

Guido's patch doesn't close the file (fp.close()) when the redirect is denied.

Both patches apparently return silently (?), while it might be better to raise an exception.
Both would deserve a test :)
History
Date User Action Args
2011-03-24 15:36:28pitrousetrecipients: + pitrou, gvanrossum, barry, georg.brandl, orsenthil, haypo, benjamin.peterson
2011-03-24 15:36:28pitrousetmessageid: <1300980988.23.0.953062548334.issue11662@psf.upfronthosting.co.za>
2011-03-24 15:36:27pitroulinkissue11662 messages
2011-03-24 15:36:27pitroucreate