Message131991
Which patch should be reviewed? They seem to be different. Senthil's patch allows a redirect to ftp while Guido's doesn't.
Senthil's patch doesn't seem to fix urllib-inherited code, only urllib2- (see FancyURLopener.redirect_internal()).
Guido's patch doesn't close the file (fp.close()) when the redirect is denied.
Both patches apparently return silently (?), while it might be better to raise an exception.
Both would deserve a test :) |
|
Date |
User |
Action |
Args |
2011-03-24 15:36:28 | pitrou | set | recipients:
+ pitrou, gvanrossum, barry, georg.brandl, orsenthil, vstinner, benjamin.peterson |
2011-03-24 15:36:28 | pitrou | set | messageid: <1300980988.23.0.953062548334.issue11662@psf.upfronthosting.co.za> |
2011-03-24 15:36:27 | pitrou | link | issue11662 messages |
2011-03-24 15:36:27 | pitrou | create | |
|