Author pitrou
Recipients dstanek, gruszczy, pitrou, srid, terry.reedy
Date 2011-03-14.16:15:33
SpamBayes Score 2.43981e-06
Marked as misclassified No
Message-id <1300119334.16.0.763698087562.issue6584@psf.upfronthosting.co.za>
In-reply-to
Content
Since the patch makes BadGzipFile a subclass of IOError, it doesn't look unreasonable.
Some nits:
- a gzipped file is not an "archive"
- the unit tests should use either the "with" statement, or try/finally blocks to properly close the file even when the test fails
- you should probably explicitly test that BadGzipFile is a subclass of IOError
History
Date User Action Args
2011-03-14 16:15:34pitrousetrecipients: + pitrou, terry.reedy, dstanek, gruszczy, srid
2011-03-14 16:15:34pitrousetmessageid: <1300119334.16.0.763698087562.issue6584@psf.upfronthosting.co.za>
2011-03-14 16:15:33pitroulinkissue6584 messages
2011-03-14 16:15:33pitroucreate