Author ned.deily
Recipients cfr, georg.brandl, hdiogenes, janssen, loewis, ned.deily, pipping, ronaldoussoren
Date 2011-03-12.12:22:17
SpamBayes Score 1.81303e-08
Marked as misclassified No
Message-id <1299932539.78.0.0358785106236.issue1099@psf.upfronthosting.co.za>
In-reply-to
Content
The patch, as is, fixes another build failure mode that has been reported (http://article.gmane.org/gmane.comp.python.general/685151):

  ./configure --enable-framework ; make

I verified that 3.2 builds without the patch fail on both 10.5 ppc and 10.4 ppc (10.4 fails thusly):

  ld: Undefined symbols:
  ___divdi3
  ___moddi3
  ___fixdfdi
  /usr/bin/libtool: internal link edit command failed

and builds works and tests pass with the patch on both.

It doesn't totally fix yet another use case (http://permalink.gmane.org/gmane.comp.python.general/685512), that of building an i386-only Python on a 10.6 64-bit-capable system:

  ./configure '--enable-framework' 'CFLAGS=-arch i386' 'CPPFLAGS=-arch i386' 'LDFLAGS=-arch i386'

With the patch, the build gets a bit further and the modified libpython make step emits the warning:
  ld: warning: in libpython3.3m.a, file was built for unsupported file format which is not the architecture being linked (x86_64)

but then the python.exe build step fails with:
  ld: warning: in Python.framework/Versions/3.3/Python, file was built for unsupported file format which is not the architecture being linked (i386)

The problem is that the libpython step (both originally and in the patch) does not take LDFLAGS into account.  Changing one line in the patch fixes that:

        $(CC) -o $(LDLIBRARY) @UNIVERSAL_ARCH_FLAGS@ -dynamiclib \
-               @FRAMEWORK_LINK_FLAGS@ \
+               @FRAMEWORK_LINK_FLAGS@ $(PY_LDFLAGS) \
                -all_load $(LIBRARY) -Wl,-single_module \
History
Date User Action Args
2011-03-12 12:22:19ned.deilysetrecipients: + ned.deily, loewis, georg.brandl, ronaldoussoren, janssen, hdiogenes, pipping, cfr
2011-03-12 12:22:19ned.deilysetmessageid: <1299932539.78.0.0358785106236.issue1099@psf.upfronthosting.co.za>
2011-03-12 12:22:18ned.deilylinkissue1099 messages
2011-03-12 12:22:17ned.deilycreate