Message130476
You're right about r/strip(), thanks (new patch in attachment).
> In your test you're checking whether returned facts
> contain every requested fact, this is not guaranteed by RFC.
Yes, but we're using a dummy FTP server returning static MLSD_DATA, so this is not important.
> Also, not sure what the last for statement
> is supposed to mean. Is it a typo?
It makes sure whether in case of directory empty (see: no data returned) we don't enter in the "for" block.
Probably it's not even necessary because this is already tested by:
self.assertRaises(StopIteration, next, self.client.mlsd())
...but... whathever. |
|
Date |
User |
Action |
Args |
2011-03-09 23:21:14 | giampaolo.rodola | set | recipients:
+ giampaolo.rodola, pitrou, eric.smith, SilentGhost, George.Dhoore |
2011-03-09 23:21:13 | giampaolo.rodola | set | messageid: <1299712873.92.0.434848599681.issue11072@psf.upfronthosting.co.za> |
2011-03-09 23:21:13 | giampaolo.rodola | link | issue11072 messages |
2011-03-09 23:21:12 | giampaolo.rodola | create | |
|