Author asdfasdfasdfasdfasdfasdfasdf
Recipients asdfasdfasdfasdfasdfasdfasdf
Date 2011-03-01.13:53:18
SpamBayes Score 3.24168e-10
Marked as misclassified No
Message-id <1298987600.46.0.512705702286.issue11359@psf.upfronthosting.co.za>
In-reply-to
Content
I don't have 3.3 installed so I cannot test it, but here is a patch for 2.6. I am sure it breaks stuff - are there tests for the subprocess module that would cover the cases that pickle was used for? 


--- subprocess.py.orig	2011-03-02 00:47:59.000000000 +1100
+++ subprocess.py	2011-03-02 00:51:27.000000000 +1100
@@ -414,7 +414,7 @@
     import select
     import errno
     import fcntl
-    import pickle
+    import json
 
 __all__ = ["Popen", "PIPE", "STDOUT", "call", "check_call", "CalledProcessError"]
 
@@ -1105,7 +1105,7 @@
                                                                    exc_value,
                                                                    tb)
                             exc_value.child_traceback = ''.join(exc_lines)
-                            os.write(errpipe_write, pickle.dumps(exc_value))
+                            os.write(errpipe_write, json.dumps(exc_value))
 
                         # This exitcode won't be reported to applications, so it
                         # really doesn't matter what we return.
@@ -1134,7 +1134,7 @@
 
             if data != "":
                 _eintr_retry_call(os.waitpid, self.pid, 0)
-                child_exception = pickle.loads(data)
+                child_exception = json.loads(data)
                 for fd in (p2cwrite, c2pread, errread):
                     if fd is not None:
                         os.close(fd)
History
Date User Action Args
2011-03-01 13:53:20asdfasdfasdfasdfasdfasdfasdfsetrecipients: + asdfasdfasdfasdfasdfasdfasdf
2011-03-01 13:53:20asdfasdfasdfasdfasdfasdfasdfsetmessageid: <1298987600.46.0.512705702286.issue11359@psf.upfronthosting.co.za>
2011-03-01 13:53:18asdfasdfasdfasdfasdfasdfasdflinkissue11359 messages
2011-03-01 13:53:18asdfasdfasdfasdfasdfasdfasdfcreate