This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.araujo
Recipients docs@python, eric.araujo, marienz, terry.reedy
Date 2011-02-09.22:21:42
SpamBayes Score 1.0030865e-13
Marked as misclassified No
Message-id <1297290103.75.0.0503800363153.issue8652@psf.upfronthosting.co.za>
In-reply-to
Content
> Removes the two instances I noticed of treating exception instances as sequences.
Looks good.

> Adds a warning explaining ``except FooException, BarException:`` does not do what you might think.
Ditto.

> There are two things I'm not entirely happy about:

> I initially wrote ``print "I/O error({0.errno}): {0.strerror}".format(e)``,
> but then noticed this string formatting trick is not mentioned in the previous chapter
> of the tutorial. Dict access (``"{0[foo]}".format(d)``) is, but attribute access
> is not. Is this worth adding to that chapter, so it can be used here?
It’s not at all a trick :)  Given that item access is already covered, I don’t think your use of attribute access would make the example harder for beginners, but I may not be the best judge.

> Binding an exception instance to a variable (using "as") is explained near the bottom
> of the section on catching exceptions, well before it is used.
> Perhaps this could do with a bit of reordering?
+1.

A note about workflow: patches should usually apply to the py3k branch, the person who commits takes care of backporting to 3.1 and 2.7.  In this case, some of your editions are not relevant for 3.x, so I suggest you use one of those workflows:
1) Make one patch for py3k and one for 2.7
2) Make one for 2.7, with comments indicating parts that apply to py3k too
3) Make one patch with edits relevant for py3k and 2.7, and another one for 2.7-only edits
History
Date User Action Args
2011-02-09 22:21:43eric.araujosetrecipients: + eric.araujo, terry.reedy, marienz, docs@python
2011-02-09 22:21:43eric.araujosetmessageid: <1297290103.75.0.0503800363153.issue8652@psf.upfronthosting.co.za>
2011-02-09 22:21:42eric.araujolinkissue8652 messages
2011-02-09 22:21:42eric.araujocreate